-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
[3.13] gh-131261: generate_sbom.py: Exclude the refresh script from SBOM (GH-131359) #144625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pythonGH-131359) (cherry picked from commit 51d3099)
|
This causes a conflict when backporting the expat update. In #144500, I currently bundle this fix with the expat update, but it seems cleaner to have it as a separate commit. @sethmlarson, does that sound good? |
sethmlarson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
| - Verify all is okay: | ||
| git diff | ||
| git status | ||
| - Regenerate the sbom file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I look at it, this is missing a step, you have to update the version in the sbom file IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you send a PR for main?
I don't think it even needs to be backported since you only do that on main.
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @encukou, I could not cleanly backport this to |
|
Sorry, @encukou, I could not cleanly backport this to |
…from SBOM (pythonGH-131359) (pythonGH-144625) - generate_sbom.py: Exclude the refresh script from SBOM - Modules/expat/refresh.sh: Expand the list of manual steps (cherry picked from commit bad4bc4) Co-authored-by: Petr Viktorin <encukou@gmail.com> (cherry picked from commit 51d3099)
|
GH-144660 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit 51d3099)